Bug 60 - We don't check for error responses to netlink operations
Summary: We don't check for error responses to netlink operations
Status: RESOLVED FIXED
Alias: None
Product: passt
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
Hardware: All Linux
: Normal minor
Assignee: David Gibson
URL:
Depends on:
Blocks:
 
Reported: 2023-06-27 06:27 UTC by David Gibson
Modified: 2023-08-04 08:38 UTC (History)
0 users

See Also:


Attachments

Description David Gibson 2023-06-27 06:27:24 UTC
nl_addr() and nl_route() perform netlink operations but don't do much to check for errors.  We check for an error on the actual send() and recv() calls, but not for error codes in the reply message.

The fact we don't trap and report errors here made bug 59 significantly harder to debug than it might otherwise have been (we silently ignored an -ENODEV error cause by that bug).
Comment 1 David Gibson 2023-07-19 05:00:56 UTC
I'm working on this in an upcoming series.
Comment 2 David Gibson 2023-08-04 08:38:13 UTC
Now fixed upstream.

Note You need to log in before you can comment on or make changes to this bug.