Bug 60

Summary:	We don't check for error responses to netlink operations
Product:	passt	Reporter:	David Gibson <dgibson>
Component:	general	Assignee:	David Gibson <dgibson>
Status:	RESOLVED FIXED
Severity:	minor
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux

Description David Gibson 2023-06-27 06:27:24 UTC

nl_addr() and nl_route() perform netlink operations but don't do much to check for errors.  We check for an error on the actual send() and recv() calls, but not for error codes in the reply message.

The fact we don't trap and report errors here made bug 59 significantly harder to debug than it might otherwise have been (we silently ignored an -ENODEV error cause by that bug).

Comment 1 David Gibson 2023-07-19 05:00:56 UTC

I'm working on this in an upcoming series.

Comment 2 David Gibson 2023-08-04 08:38:13 UTC

Now fixed upstream.