Summary: | pasta does not filter out unneeded routes on kernel < 4.20 | ||
---|---|---|---|
Product: | passt | Reporter: | runsisi <runsisi> |
Component: | pasta | Assignee: | nobody |
Status: | IN_PROGRESS --- | ||
Severity: | normal | CC: | sbrivio |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux |
Description
runsisi
2024-04-15 00:41:39 UTC
This was originally taken care of, for addresses: commit e89da3cf03b2 ("netlink: Add functionality to copy addresses from outer namespace") explains how. It looks like commit dee75941801a ("netlink: Make nl_*_dup() use a separate datagram for each request") accidentally removed the AF_UNSPEC assignment for ifa_family. So we should also fix that. Similarly, for routes, setting AF_UNSPEC to rtm_family for interface-mismatching routes should do the trick. Patches at https://archives.passt.top/passt-dev/20240423204125.3424982-1-sbrivio@redhat.com/, pending review (testing appreciated). applied the second patch (since the first is already on master), and tested on aarch64 with kernel 4.19.90 and amd64 with kernel 6.8.7, it works fine. tested v2 on aarch64 with kernel 4.19.90 and amd64 with kernel 6.8.7, works fine. thanks! Thanks for testing and re-testing! Patch merged now (not released yet). |